From 2d76f6d575959f3e380f4dc61a8ad3ec417c127c Mon Sep 17 00:00:00 2001 From: Alex Mykyta Date: Sat, 25 Mar 2023 22:59:23 -0700 Subject: [PATCH] Grammar --- docs/dev_notes/Validation Needed | 2 +- docs/udps/read_buffering.rst | 2 +- src/peakrdl_regblock/udps/rw_buffering.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/dev_notes/Validation Needed b/docs/dev_notes/Validation Needed index 4fab5f0..463c57f 100644 --- a/docs/dev_notes/Validation Needed +++ b/docs/dev_notes/Validation Needed @@ -78,7 +78,7 @@ X Illegal property references: next is this ever illegal? -X If a node ispresent=true, and any of it's properties are a reference, +X If a node ispresent=true, and any of its properties are a reference, then those references' ispresent shall also be true This is an explicit clause in the spec: 5.3.1-i diff --git a/docs/udps/read_buffering.rst b/docs/udps/read_buffering.rst index 9c547c0..28d2af8 100644 --- a/docs/udps/read_buffering.rst +++ b/docs/udps/read_buffering.rst @@ -34,7 +34,7 @@ enabled by compiling the following file along with your design: ``buffer_reads`` * Assigned value is a boolean. * If true, enables double-buffering of software reads of this register. - * The read buffer will load the register's field values when it's trigger + * The read buffer will load the register's field values when its trigger event is asserted. * Unless specified otherwise, the buffer trigger occurs when the lowest address of the buffered register is read. diff --git a/src/peakrdl_regblock/udps/rw_buffering.py b/src/peakrdl_regblock/udps/rw_buffering.py index 5c794fc..428fd08 100644 --- a/src/peakrdl_regblock/udps/rw_buffering.py +++ b/src/peakrdl_regblock/udps/rw_buffering.py @@ -23,7 +23,7 @@ class xBufferTrigger(UDPDefinition): # Trigger can reference a vector, but only if it is a single-bit if value.width != 1: self.msg.error( - "%s '%s' references %s '%s' but it's width is not 1" + "%s '%s' references %s '%s' but its width is not 1" % ( type(node.inst).__name__.lower(), node.inst_name, type(value.inst).__name__.lower(), value.inst_name @@ -42,7 +42,7 @@ class xBufferTrigger(UDPDefinition): # Trigger can reference a property, but only if it is a single-bit if value.width != 1: self.msg.error( - "%s '%s' references property '%s->%s' but it's width is not 1" + "%s '%s' references property '%s->%s' but its width is not 1" % ( type(node.inst).__name__.lower(), node.inst_name, value.node.inst_name, value.name,