Type hinting cleanup

src/peakrdl_regblock/field_logic/bases.py

@@ -99,6 +99,7 @@ class NextStateConditional:
             <field>.next = <next value>
             <field>.load_next = '1;
         """
+        raise NotImplementedError
 
     def get_extra_combo_signals(self, field: 'FieldNode') -> List[SVLogic]:
         """

src/peakrdl_regblock/field_logic/hw_write.py

@@ -46,7 +46,7 @@ class WEWrite(AlwaysWrite):
     def is_match(self, field: 'FieldNode') -> bool:
         return (
             field.is_hw_writable
-            and field.get_property('we')
+            and bool(field.get_property('we'))
         )
 
     def get_predicate(self, field: 'FieldNode') -> str:
@@ -64,7 +64,7 @@ class WELWrite(AlwaysWrite):
     def is_match(self, field: 'FieldNode') -> bool:
         return (
             field.is_hw_writable
-            and field.get_property('wel')
+            and bool(field.get_property('wel'))
         )
 
     def get_predicate(self, field: 'FieldNode') -> str:

src/peakrdl_regblock/field_logic/sw_onwrite.py

@@ -1,4 +1,4 @@
-from typing import TYPE_CHECKING, List
+from typing import TYPE_CHECKING, List, Optional
 
 from systemrdl.rdltypes import OnWriteType
 
@@ -10,7 +10,7 @@ if TYPE_CHECKING:
 # TODO: implement sw=w1 "write once" fields
 
 class _OnWrite(NextStateConditional):
-    onwritetype = None # type: OnWriteType
+    onwritetype: Optional[OnWriteType] = None
     def is_match(self, field: 'FieldNode') -> bool:
         return field.is_sw_writable and field.get_property('onwrite') == self.onwritetype