Add signed/fixedpoint properties (#140)
* declared intwidth, fracwidth, and is_signed UDPs * fix boolean type name in UDP definition * generate hwif fields with fixedpoint indices * make "counter" and "encode" properties mutualy exclusive with signed/fixedpoint * add signed/unsigned to hwif * improved fixedpoint error messages, added validation tests * added fixedpoint tests * fixedpoint/signed not allowed for signal components * added signed/fixedpoint UDP docs * handle single-bit fixedpoint numbers * fix too many positional arguments lint * changed spelling of fixedpoint to fixed-point * use "logic" in place of "unsigned logic" * split signed and fixedpoint docs, added examples * allow enums with is_signed=false * split signed and fixedpoint implementations * assorted nits picked * updated is_signed validation unit test
This commit is contained in:
9
tests/test_validation_errors/fixedpoint_counter.rdl
Normal file
9
tests/test_validation_errors/fixedpoint_counter.rdl
Normal file
@@ -0,0 +1,9 @@
|
||||
addrmap top {
|
||||
reg {
|
||||
field {
|
||||
sw = rw; hw = r;
|
||||
intwidth = 4;
|
||||
counter;
|
||||
} fixedpoint_counter[8] = 0;
|
||||
} r1;
|
||||
};
|
||||
15
tests/test_validation_errors/fixedpoint_enum.rdl
Normal file
15
tests/test_validation_errors/fixedpoint_enum.rdl
Normal file
@@ -0,0 +1,15 @@
|
||||
addrmap top {
|
||||
reg {
|
||||
enum test_enum {
|
||||
zero = 2'b00;
|
||||
one = 2'b01;
|
||||
two = 2'b10;
|
||||
three = 2'b11;
|
||||
};
|
||||
field {
|
||||
sw = rw; hw = r;
|
||||
fracwidth = 0;
|
||||
encode = test_enum;
|
||||
} fixedpoint_enum[2] = 0;
|
||||
} r1;
|
||||
};
|
||||
@@ -0,0 +1,9 @@
|
||||
addrmap top {
|
||||
reg {
|
||||
field {
|
||||
sw = rw; hw = r;
|
||||
intwidth = 4;
|
||||
fracwidth = 5;
|
||||
} num[8] = 0;
|
||||
} r1;
|
||||
};
|
||||
14
tests/test_validation_errors/signed_counter.rdl
Normal file
14
tests/test_validation_errors/signed_counter.rdl
Normal file
@@ -0,0 +1,14 @@
|
||||
addrmap top {
|
||||
reg {
|
||||
field {
|
||||
sw = rw; hw = r;
|
||||
is_signed = false;
|
||||
counter;
|
||||
} unsigned_counter[8] = 0;
|
||||
field {
|
||||
sw = rw; hw = r;
|
||||
is_signed;
|
||||
counter;
|
||||
} signed_counter[8] = 0;
|
||||
} r1;
|
||||
};
|
||||
20
tests/test_validation_errors/signed_enum.rdl
Normal file
20
tests/test_validation_errors/signed_enum.rdl
Normal file
@@ -0,0 +1,20 @@
|
||||
addrmap top {
|
||||
reg {
|
||||
enum test_enum {
|
||||
zero = 2'b00;
|
||||
one = 2'b01;
|
||||
two = 2'b10;
|
||||
three = 2'b11;
|
||||
};
|
||||
field {
|
||||
sw = rw; hw = r;
|
||||
is_signed = false;
|
||||
encode = test_enum;
|
||||
} unsigned_enum[2] = 0;
|
||||
field {
|
||||
sw = rw; hw = r;
|
||||
is_signed;
|
||||
encode = test_enum;
|
||||
} signed_enum[2] = 0;
|
||||
} r1;
|
||||
};
|
||||
@@ -89,3 +89,33 @@ class TestValidationErrors(BaseTestCase):
|
||||
"unsynth_reset2.rdl",
|
||||
"A field that uses an asynchronous reset cannot use a dynamic reset value. This is not synthesizable.",
|
||||
)
|
||||
|
||||
def test_fixedpoint_counter(self) -> None:
|
||||
self.assert_validate_error(
|
||||
"fixedpoint_counter.rdl",
|
||||
"Fixed-point representations are not supported for counter fields.",
|
||||
)
|
||||
|
||||
def test_fixedpoint_enum(self) -> None:
|
||||
self.assert_validate_error(
|
||||
"fixedpoint_enum.rdl",
|
||||
"Fixed-point representations are not supported for fields encoded as an enum.",
|
||||
)
|
||||
|
||||
def test_fixedpoint_inconsistent_width(self) -> None:
|
||||
self.assert_validate_error(
|
||||
"fixedpoint_inconsistent_width.rdl",
|
||||
r"Number of integer bits \(4\) plus number of fractional bits \(5\) must be equal to the width of the component \(8\).",
|
||||
)
|
||||
|
||||
def test_signed_counter(self) -> None:
|
||||
self.assert_validate_error(
|
||||
"signed_counter.rdl",
|
||||
"The property is_signed=true is not supported for counter fields.",
|
||||
)
|
||||
|
||||
def test_signed_enum(self) -> None:
|
||||
self.assert_validate_error(
|
||||
"signed_enum.rdl",
|
||||
"The property is_signed=true is not supported for fields encoded as an enum."
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user