bslathi19/buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

utils/scanpypi: fix flake8 errors

Browse Source 
Commit e43c0509442c746bea305aa2b0a5f7ff5adfd142 introduced two flake8
errors:

utils/scanpypi:300:26: E231 missing whitespace after ','
utils/scanpypi:302:9: F841 local variable 'setup' is assigned to but never used

The first one is easily fixed. The second one needs a little bit of
explanation. Before commit e43c0509, the return value of
imp.load_module() was used to be able to explicitly call the 'setup'
function in it in case the metadata was not populated. Since that
commit, calling that function is no longer needed, since setup.py is
executed in exactly the same way as when it's run from the command line,
so if that doesn't work, it's completely broken anyway. Therefore, we
can simply discard the return value of imp.load_module().

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(cherry picked from commit f982f7043419dea2d21ebe20c1b383633a517674)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Arnout Vandecappelle (Essensium/Mind)
2021-07-27 23:29:07 +02:00
committed by Peter Korsgaard
parent 2d8ba74fe3
commit ecba2d0b6c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
utils/scanpypi
View File

@@ -299,7 +299,7 @@ class BuildrootPackage():
os.chdir(self.tmp_extract) os.chdir(self.tmp_extract)
sys.path.insert(0, self.tmp_extract) sys.path.insert(0, self.tmp_extract)
s_file, s_path, s_desc = imp.find_module('setup', [self.tmp_extract]) s_file, s_path, s_desc = imp.find_module('setup', [self.tmp_extract])
setup = imp.load_module('__main__', s_file, s_path, s_desc) imp.load_module('__main__', s_file, s_path, s_desc)
if self.metadata_name in self.setup_args: if self.metadata_name in self.setup_args:
pass pass
elif self.metadata_name.replace('_', '-') in self.setup_args: elif self.metadata_name.replace('_', '-') in self.setup_args: