Polishing the peripherals (and counter) interface.

This commit is contained in:
sidney
2024-12-19 03:48:15 +01:00
parent 8a7cd9c632
commit 5239d3a11b
5 changed files with 117 additions and 102 deletions

View File

@@ -4108,7 +4108,7 @@ unsigned ExecuteInsn (void)
if (HaveNMIRequest) { if (HaveNMIRequest) {
HaveNMIRequest = 0; HaveNMIRequest = 0;
PRegs.counter_nmi_events += 1; Peripherals.Counter.nmi_events += 1;
PUSH (PCH); PUSH (PCH);
PUSH (PCL); PUSH (PCL);
@@ -4124,7 +4124,7 @@ unsigned ExecuteInsn (void)
} else if (HaveIRQRequest && GET_IF () == 0) { } else if (HaveIRQRequest && GET_IF () == 0) {
HaveIRQRequest = 0; HaveIRQRequest = 0;
PRegs.counter_irq_events += 1; Peripherals.Counter.irq_events += 1;
PUSH (PCH); PUSH (PCH);
PUSH (PCL); PUSH (PCL);
@@ -4146,11 +4146,11 @@ unsigned ExecuteInsn (void)
Handlers[CPU][OPC] (); Handlers[CPU][OPC] ();
/* Increment the instruction counter by one.NMIs and IRQs are counted separately. */ /* Increment the instruction counter by one.NMIs and IRQs are counted separately. */
PRegs.counter_instructions += 1; Peripherals.Counter.cpu_instructions += 1;
} }
/* Increment the 64-bit clock cycle counter with the cycle count for the instruction that we just executed */ /* Increment the 64-bit clock cycle counter with the cycle count for the instruction that we just executed */
PRegs.counter_clock_cycles += Cycles; Peripherals.Counter.clock_cycles += Cycles;
/* Return the number of clock cycles needed by this insn */ /* Return the number of clock cycles needed by this insn */
return Cycles; return Cycles;

View File

@@ -118,7 +118,7 @@ void SimExit (int Code)
/* Exit the simulation with an exit code */ /* Exit the simulation with an exit code */
{ {
if (PrintCycles) { if (PrintCycles) {
fprintf (stdout, "%" PRIu64 " cycles\n", PRegs.counter_clock_cycles); fprintf (stdout, "%" PRIu64 " cycles\n", Peripherals.Counter.clock_cycles);
} }
exit (Code); exit (Code);
} }

View File

@@ -62,7 +62,7 @@ void MemWriteByte (uint16_t Addr, uint8_t Val)
if ((PERIPHERALS_APERTURE_BASE_ADDRESS <= Addr) && (Addr <= PERIPHERALS_APERTURE_LAST_ADDRESS)) if ((PERIPHERALS_APERTURE_BASE_ADDRESS <= Addr) && (Addr <= PERIPHERALS_APERTURE_LAST_ADDRESS))
{ {
/* Defer the the memory-mapped peripherals handler for this write. */ /* Defer the the memory-mapped peripherals handler for this write. */
PeripheralWriteByte (Addr - PERIPHERALS_APERTURE_BASE_ADDRESS, Val); PeripheralsWriteByte (Addr - PERIPHERALS_APERTURE_BASE_ADDRESS, Val);
} else { } else {
/* Write to the Mem array. */ /* Write to the Mem array. */
Mem[Addr] = Val; Mem[Addr] = Val;
@@ -86,7 +86,7 @@ uint8_t MemReadByte (uint16_t Addr)
if ((PERIPHERALS_APERTURE_BASE_ADDRESS <= Addr) && (Addr <= PERIPHERALS_APERTURE_LAST_ADDRESS)) if ((PERIPHERALS_APERTURE_BASE_ADDRESS <= Addr) && (Addr <= PERIPHERALS_APERTURE_LAST_ADDRESS))
{ {
/* Defer the the memory-mapped peripherals handler for this read. */ /* Defer the the memory-mapped peripherals handler for this read. */
return PeripheralReadByte (Addr - PERIPHERALS_APERTURE_BASE_ADDRESS); return PeripheralsReadByte (Addr - PERIPHERALS_APERTURE_BASE_ADDRESS);
} else { } else {
/* Read from the Mem array. */ /* Read from the Mem array. */
return Mem[Addr]; return Mem[Addr];

View File

@@ -40,8 +40,8 @@
/* The peripheral registers. */ /* The system-wide state of the peripherals */
PeripheralRegs PRegs; Sim65Peripherals Peripherals;
@@ -51,46 +51,37 @@ PeripheralRegs PRegs;
static uint64_t get_uint64_wallclock_time(void) void PeripheralsWriteByte (uint8_t Addr, uint8_t Val)
{ /* Write a byte to a memory location in the peripherals address aperture. */
struct timespec ts;
int result = clock_gettime(CLOCK_REALTIME, &ts);
if (result != 0)
{
// On failure, time will be set to the max value.
return 0xffffffffffffffff;
}
/* Return time since the 1-1-1970 epoch, in nanoseconds.
* Note that this time may be off by an integer number of seconds, as POSIX
* maintaines that all days are 86,400 seconds long, which is not true due to
* leap seconds.
*/
return ts.tv_sec * 1000000000 + ts.tv_nsec;
}
void PeripheralWriteByte (uint8_t Addr, uint8_t Val)
/* Write a byte to a memory location in the peripheral address aperture. */
{ {
switch (Addr) { switch (Addr) {
case PERIPHERALS_ADDRESS_OFFSET_LATCH: { case PERIPHERALS_COUNTER_ADDRESS_OFFSET_LATCH: {
/* A write to the "latch" register performs a simultaneous latch of all registers */ /* A write to the "latch" register performs a simultaneous latch of all registers. */
/* Latch the current wallclock time first. */ /* Latch the current wallclock time first. */
PRegs.latched_wallclock_time = get_uint64_wallclock_time(); struct timespec ts;
int result = clock_gettime(CLOCK_REALTIME, &ts);
if (result != 0) {
/* Unable to read time. Report max uint64 value for both fields. */
Peripherals.Counter.latched_wallclock_time = 0xffffffffffffffff;
Peripherals.Counter.latched_wallclock_time_split = 0xffffffffffffffff;
} else {
/* Number of nanoseconds since 1-1-1970. */
Peripherals.Counter.latched_wallclock_time = 1000000000u * ts.tv_sec + ts.tv_nsec;
/* High word is number of seconds, low word is number of nanoseconds. */
Peripherals.Counter.latched_wallclock_time_split = (ts.tv_sec << 32) | ts.tv_nsec;
}
/* Now latch all the cycles maintained by the processor. */ /* Latch the counters that reflect the state of the processor. */
PRegs.latched_counter_clock_cycles = PRegs.counter_clock_cycles; Peripherals.Counter.latched_clock_cycles = Peripherals.Counter.clock_cycles;
PRegs.latched_counter_instructions = PRegs.counter_instructions; Peripherals.Counter.latched_cpu_instructions = Peripherals.Counter.cpu_instructions;
PRegs.latched_counter_irq_events = PRegs.counter_irq_events; Peripherals.Counter.latched_irq_events = Peripherals.Counter.irq_events;
PRegs.latched_counter_nmi_events = PRegs.counter_nmi_events; Peripherals.Counter.latched_nmi_events = Peripherals.Counter.nmi_events;
break; break;
} }
case PERIPHERALS_ADDRESS_OFFSET_SELECT: { case PERIPHERALS_COUNTER_ADDRESS_OFFSET_SELECT: {
/* Set the value of the visibility-selection register. */ /* Set the value of the visibility-selection register. */
PRegs.visible_latch_register = Val; Peripherals.Counter.visible_latch_register = Val;
break; break;
} }
default: { default: {
@@ -101,33 +92,34 @@ void PeripheralWriteByte (uint8_t Addr, uint8_t Val)
uint8_t PeripheralReadByte (uint8_t Addr) uint8_t PeripheralsReadByte (uint8_t Addr)
/* Read a byte from a memory location in the peripheral address aperture. */ /* Read a byte from a memory location in the peripherals address aperture. */
{ {
switch (Addr) { switch (Addr) {
case PERIPHERALS_ADDRESS_OFFSET_SELECT: { case PERIPHERALS_COUNTER_ADDRESS_OFFSET_SELECT: {
return PRegs.visible_latch_register; return Peripherals.Counter.visible_latch_register;
} }
case PERIPHERALS_ADDRESS_OFFSET_REG64 + 0: case PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE + 0:
case PERIPHERALS_ADDRESS_OFFSET_REG64 + 1: case PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE + 1:
case PERIPHERALS_ADDRESS_OFFSET_REG64 + 2: case PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE + 2:
case PERIPHERALS_ADDRESS_OFFSET_REG64 + 3: case PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE + 3:
case PERIPHERALS_ADDRESS_OFFSET_REG64 + 4: case PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE + 4:
case PERIPHERALS_ADDRESS_OFFSET_REG64 + 5: case PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE + 5:
case PERIPHERALS_ADDRESS_OFFSET_REG64 + 6: case PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE + 6:
case PERIPHERALS_ADDRESS_OFFSET_REG64 + 7: { case PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE + 7: {
/* Read from any of the eight counter bytes. /* Read from any of the eight counter bytes.
* The first byte is the 64 bit value's LSB, the seventh byte is its MSB. * The first byte is the 64 bit value's LSB, the seventh byte is its MSB.
*/ */
unsigned byte_select = Addr - PERIPHERALS_ADDRESS_OFFSET_REG64; /* 0 .. 7 */ unsigned byte_select = Addr - PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE; /* 0 .. 7 */
uint64_t value; uint64_t value;
switch (PRegs.visible_latch_register) { switch (Peripherals.Counter.visible_latch_register) {
case PERIPHERALS_REG64_SELECT_CLOCKCYCLE_COUNTER: value = PRegs.latched_counter_clock_cycles; break; case PERIPHERALS_COUNTER_SELECT_CLOCKCYCLE_COUNTER: value = Peripherals.Counter.latched_clock_cycles; break;
case PERIPHERALS_REG64_SELECT_INSTRUCTION_COUNTER: value = PRegs.latched_counter_instructions; break; case PERIPHERALS_COUNTER_SELECT_INSTRUCTION_COUNTER: value = Peripherals.Counter.latched_cpu_instructions; break;
case PERIPHERALS_REG64_SELECT_IRQ_COUNTER: value = PRegs.latched_counter_irq_events; break; case PERIPHERALS_COUNTER_SELECT_IRQ_COUNTER: value = Peripherals.Counter.latched_irq_events; break;
case PERIPHERALS_REG64_SELECT_NMI_COUNTER: value = PRegs.latched_counter_nmi_events; break; case PERIPHERALS_COUNTER_SELECT_NMI_COUNTER: value = Peripherals.Counter.latched_nmi_events; break;
case PERIPHERALS_REG64_SELECT_WALLCLOCK_TIME: value = PRegs.latched_wallclock_time; break; case PERIPHERALS_COUNTER_SELECT_WALLCLOCK_TIME: value = Peripherals.Counter.latched_wallclock_time; break;
default: value = 0; /* Reading from a non-supported register will yield 0. */ case PERIPHERALS_COUNTER_SELECT_WALLCLOCK_TIME_SPLIT: value = Peripherals.Counter.latched_wallclock_time_split; break;
default: value = 0; /* Reading from a non-existent register will yield 0. */
} }
/* Return the desired byte of the latched counter. 0==LSB, 7==MSB. */ /* Return the desired byte of the latched counter. 0==LSB, 7==MSB. */
return value >> (byte_select * 8); return value >> (byte_select * 8);
@@ -144,16 +136,19 @@ uint8_t PeripheralReadByte (uint8_t Addr)
void PeripheralsInit (void) void PeripheralsInit (void)
/* Initialize the peripheral registers */ /* Initialize the peripheral registers */
{ {
PRegs.counter_clock_cycles = 0; /* Initialize the COUNTER peripheral */
PRegs.counter_instructions = 0;
PRegs.counter_irq_events = 0;
PRegs.counter_nmi_events = 0;
PRegs.latched_counter_clock_cycles = 0; Peripherals.Counter.clock_cycles = 0;
PRegs.latched_counter_instructions = 0; Peripherals.Counter.cpu_instructions = 0;
PRegs.latched_counter_irq_events = 0; Peripherals.Counter.irq_events = 0;
PRegs.latched_counter_nmi_events = 0; Peripherals.Counter.nmi_events = 0;
PRegs.latched_wallclock_time = 0;
PRegs.visible_latch_register = 0; Peripherals.Counter.latched_clock_cycles = 0;
Peripherals.Counter.latched_cpu_instructions = 0;
Peripherals.Counter.latched_irq_events = 0;
Peripherals.Counter.latched_nmi_events = 0;
Peripherals.Counter.latched_wallclock_time = 0;
Peripherals.Counter.latched_wallclock_time_split = 0;
Peripherals.Counter.visible_latch_register = 0;
} }

View File

@@ -35,44 +35,64 @@
#include <stdint.h> #include <stdint.h>
#define PERIPHERALS_APERTURE_BASE_ADDRESS 0xffc0 /* The memory range where the memory-mapped peripherals can be accessed. */
#define PERIPHERALS_APERTURE_LAST_ADDRESS 0xffc9
#define PERIPHERALS_ADDRESS_OFFSET_LATCH 0x00 #define PERIPHERALS_APERTURE_BASE_ADDRESS 0xffc0
#define PERIPHERALS_ADDRESS_OFFSET_SELECT 0x01 #define PERIPHERALS_APERTURE_LAST_ADDRESS 0xffc9
#define PERIPHERALS_ADDRESS_OFFSET_REG64 0x02
#define PERIPHERALS_LATCH (PERIPHERALS_APERTURE_BASE_ADDRESS + PERIPHERALS_ADDRESS_OFFSET_LATCH) /* Declarations for the COUNTER peripheral (currently the only peripheral). */
#define PERIPHERALS_SELECT (PERIPHERALS_APERTURE_BASE_ADDRESS + PERIPHERALS_ADDRESS_OFFSET_SELECT)
#define PERIPHERALS_REG64 (PERIPHERALS_APERTURE_BASE_ADDRESS + PERIPHERALS_ADDRESS_OFFSET_REG64)
#define PERIPHERALS_REG64_SELECT_CLOCKCYCLE_COUNTER 0x00 #define PERIPHERALS_COUNTER_ADDRESS_OFFSET_LATCH 0x00
#define PERIPHERALS_REG64_SELECT_INSTRUCTION_COUNTER 0x01 #define PERIPHERALS_COUNTER_ADDRESS_OFFSET_SELECT 0x01
#define PERIPHERALS_REG64_SELECT_IRQ_COUNTER 0x02 #define PERIPHERALS_COUNTER_ADDRESS_OFFSET_VALUE 0x02
#define PERIPHERALS_REG64_SELECT_NMI_COUNTER 0x03
#define PERIPHERALS_REG64_SELECT_WALLCLOCK_TIME 0x80 #define PERIPHERALS_COUNTER_LATCH (PERIPHERALS_APERTURE_BASE_ADDRESS + PERIPHERALS_ADDRESS_OFFSET_COUNTER_LATCH)
#define PERIPHERALS_COUNTER_SELECT (PERIPHERALS_APERTURE_BASE_ADDRESS + PERIPHERALS_ADDRESS_OFFSET_COUNTER_SELECT)
#define PERIPHERALS_COUNTER_VALUE (PERIPHERALS_APERTURE_BASE_ADDRESS + PERIPHERALS_ADDRESS_OFFSET_COUNTER)
#define PERIPHERALS_COUNTER_SELECT_CLOCKCYCLE_COUNTER 0x00
#define PERIPHERALS_COUNTER_SELECT_INSTRUCTION_COUNTER 0x01
#define PERIPHERALS_COUNTER_SELECT_IRQ_COUNTER 0x02
#define PERIPHERALS_COUNTER_SELECT_NMI_COUNTER 0x03
#define PERIPHERALS_COUNTER_SELECT_WALLCLOCK_TIME 0x80
#define PERIPHERALS_COUNTER_SELECT_WALLCLOCK_TIME_SPLIT 0x81
typedef struct { typedef struct {
/* the invisible counters that are continuously updated */ /* The invisible counters that keep processor state. */
uint64_t counter_clock_cycles; uint64_t clock_cycles;
uint64_t counter_instructions; uint64_t cpu_instructions;
uint64_t counter_irq_events; uint64_t irq_events;
uint64_t counter_nmi_events; uint64_t nmi_events;
/* latched counters upon a write to the 'latch' address. /* Latched counters upon a write to the PERIPHERALS_COUNTER_LATCH address.
* One of these will be visible (read only) through an each-byte aperture. */ * One of these will be visible (read only) through an eight-byte aperture.
uint64_t latched_counter_clock_cycles; * The purpose of these latched registers is to read 64-bit values one byte
uint64_t latched_counter_instructions; * at a time, without having to worry that their content will change along
uint64_t latched_counter_irq_events; * the way.
uint64_t latched_counter_nmi_events; */
uint64_t latched_clock_cycles;
uint64_t latched_cpu_instructions;
uint64_t latched_irq_events;
uint64_t latched_nmi_events;
uint64_t latched_wallclock_time; uint64_t latched_wallclock_time;
/* Select which of the five latched registers will be visible. uint64_t latched_wallclock_time_split;
* This is a Read/Write byte-wide register. /* Select which of the six latched registers will be visible.
* If a non-existent register is selected, the 8-byte aperture will read as zero. * This is a single byte, read/write register, accessible via address PERIPHERALS_COUNTER_SELECT.
* If a non-existent latch register is selected, the PERIPHERALS_REGS64 value will be zero.
*/ */
uint8_t visible_latch_register; uint8_t visible_latch_register;
} PeripheralRegs; } CounterPeripheral;
extern PeripheralRegs PRegs;
/* Declare the 'Sim65Peripherals' type and its single instance 'Peripherals'. */
typedef struct {
/* State of the peripherals simulated by sim65.
* Currently, there is only one: the COUNTER peripheral. */
CounterPeripheral Counter;
} Sim65Peripherals;
extern Sim65Peripherals Peripherals;
/*****************************************************************************/ /*****************************************************************************/
/* Code */ /* Code */
@@ -80,11 +100,11 @@ extern PeripheralRegs PRegs;
void PeripheralWriteByte (uint8_t Addr, uint8_t Val); void PeripheralsWriteByte (uint8_t Addr, uint8_t Val);
/* Write a byte to a memory location in the peripheral address aperture. */ /* Write a byte to a memory location in the peripheral address aperture. */
uint8_t PeripheralReadByte (uint8_t Addr); uint8_t PeripheralsReadByte (uint8_t Addr);
/* Read a byte from a memory location in the peripheral address aperture. */ /* Read a byte from a memory location in the peripheral address aperture. */